Re-arm the post-checkout billing poll across effect recycles - #1750
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 5018043 | Aug 26 2026, 04:27 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 5018043 | Commit Preview URL Branch Preview URL |
Aug 26 2026, 04:26 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
billing-trial-checkout-stalefailure on cloud 15of16 that has been red on every run containing #1748 (SPA mode), including main.The post-checkout reconciliation poll lived entirely inside a single-shot effect keyed on the URL return marker. Under SPA mode the shell re-runs effects shortly after mount (auth seeds a frame after first paint), and the re-run saw the already-stripped marker: the cleanup killed the interval and nothing re-armed it. The page sat on "Activating" forever — the server log for a failing run shows zero
/api/billingrequests after the return load.Now only the marker consumption is single-shot; the poll keys off the surviving
finalizingPlanstate, so an effect recycle re-arms it. The timeout is anchored to when the marker was consumed (recycles cannot extend it), and refetch goes through a ref so the interval always calls the current billing client.Checks: lint, typecheck, focused
cloud/billing-trial-checkout-stale.test.ts(reproduced failing oneb34d049d, passes with the fix; server log shows the poll ticking again).